smyalygames/quartz
Template
1
0
Fork 0
mirror of https://github.com/jackyzha0/quartz.git synced 2025-05-18 06:24:22 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(popovers): clear id to avoid anchor jumps within popover
Some checks are pending
Build and Test / build-and-test (macos-latest) (push) Waiting to run
Details
Build and Test / build-and-test (windows-latest) (push) Waiting to run
Details
Build and Test / build-and-test (ubuntu-latest) (push) Has been skipped
Details
Build and Test / publish-tag (push) Has been skipped
Details

Browse Source
This commit is contained in:
Jacky Zhao 2025-03-10 00:08:06 -07:00
parent d618a4e3f3
commit 8d33608808
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
quartz/components/scripts/popover.inline.ts
View File

@ -82,6 +82,8 @@ async function mouseEnterHandler(
const contents = await response.text()
const html = p.parseFromString(contents, "text/html")
normalizeRelativeURLs(html, targetUrl)
// strip all IDs from elements to prevent duplicates
html.querySelectorAll("[id]").forEach((el) => el.removeAttribute("id"))
const elts = [...html.getElementsByClassName("popover-hint")]
if (elts.length === 0) return

4
quartz/styles/base.scss
View File

@ -351,6 +351,10 @@ h6 {
&[id]:hover > a {
opacity: 1;
}
&:not([id]) > a[role="anchor"] {
display: none;
}
}
// typography improvements